-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored Variant setters/getters #43371
Conversation
reduz
commented
Nov 7, 2020
- Discern between named, indexed and keyed
- Get direct access to functions for typed GDScript and GDNative bindings
- Small changes to some classes in order to work with the new setget binder
For me, this build always crash when trying to open editor or project manager - Valgrind log(Godot opens 10 minutes)
|
@aaronfranke nice catches, thanks! fixing in my local branch as I have some other fixes in the works. |
@qarmin fixed the crash locally, I thought everything worked fine but was running an old binary :( will force push with fixes in a bit |
b61c329
to
a547fe6
Compare
Code
shows error |
@qarmin good catch! I completely forgot we allow negative indices in arrays! |
-Discern between named, indexed and keyed -Get direct access to functions for typed GDScript and GDNative bindings -Small changes to some classes in order to work with the new setget binder
a547fe6
to
05de7ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM