Move and add new RegEx test cases #43781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Nov 22, 2020
Test cases for 'RegEx' are moved from 'test_string.h' to own test suite in 'test_regex.h'. Additionally, new tests are introduced and '_init' is removed as it isn't implemented/used anywhere.
maxmutant
force-pushed
the
regex_unit_tests
branch
from
7484ff6
to
7edb50a
Compare
akien-mga
approved these changes
Nov 23, 2020
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
|
Yeah! Thanks 😄 |
99 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test cases for 'RegEx' are moved from 'test_string.h' to own test suite
in 'test_regex.h'. Additionally, new tests are introduced and '_init' is
removed, as it isn't implemented/used anywhere.
This is part of #43440