Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the brightness factor for highlighted 3D gizmos to a variable #44500

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Dec 18, 2020

The alpha component of a Color also defaults to 1.0, so we don't have to specify it.

See 8522ac7#r45230326.

@Calinou Calinou added cherrypick:3.x Considered for cherry-picking into a future 3.x release enhancement topic:codestyle labels Dec 18, 2020
@Calinou Calinou added this to the 4.0 milestone Dec 18, 2020
@Calinou Calinou force-pushed the editor-gizmo-hover-brightness-variable branch from b9774f7 to 47c71e6 Compare December 19, 2020 01:54
@Calinou Calinou force-pushed the editor-gizmo-hover-brightness-variable branch from 47c71e6 to 507e9b1 Compare December 27, 2020 21:21
@akien-mga akien-mga merged commit 783ec77 into godotengine:master Dec 27, 2020
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.2.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Dec 29, 2020
@Calinou Calinou deleted the editor-gizmo-hover-brightness-variable branch March 31, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants