Use real_t in 2D nodes #45571
Merged
Use real_t in 2D nodes #45571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronfranke
force-pushed
the
node2d-real_t
branch
from
d182ce6
to
6271b39
Compare
aaronfranke
force-pushed
the
node2d-real_t
branch
from
6271b39
to
1a1126e
Compare
aaronfranke
force-pushed
the
node2d-real_t
branch
from
1a1126e
to
74d0856
Compare
aaronfranke
changed the title
aaronfranke
force-pushed
the
node2d-real_t
branch
2 times, most recently
from
1b7488e
to
d1aaa67
Compare
KoBeWi
reviewed
Mar 8, 2021
aaronfranke
force-pushed
the
node2d-real_t
branch
from
d1aaa67
to
16c9005
Compare
KoBeWi
requested changes
Mar 19, 2021
There was a problem hiding this comment.
As I mentioned in my last comment, it would be better if the TileMap changes were removed. This PR is only relevant for 4.0 and TileMap in 4.0 is getting a full rewrite, so doing changes in other PRs is rather useless. Unless you don't mind waiting and rebasing until the rework is merged.
aaronfranke
force-pushed
the
node2d-real_t
branch
from
16c9005
to
6811a45
Compare
KoBeWi
approved these changes
Mar 19, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to other recent
real_tPRs I've made, but this PR specifically focuses on 2D nodes.All code related to time was intentionally left unchanged. Code that works with time should be
double, notreal_t, but that would change behavior, so I think it's worth doing in a separate PR.