Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix out of bounds array access on DisplayServerX11 code #46517

Merged
merged 1 commit into from
Feb 28, 2021
Merged

Fix out of bounds array access on DisplayServerX11 code #46517

merged 1 commit into from
Feb 28, 2021

Conversation

pdfrod
Copy link
Contributor

@pdfrod pdfrod commented Feb 28, 2021 •
edited by akien-mga
Loading

The problem happened on methods screen_get_position,
screen_get_usable_rect and window_set_current_screen when they were
passed a negative screen value.

Fixes: #46184
Fixes: #46185
Fixes: #46186

@pdfrod
Fix out of bounds array access on DisplayServerX11 code
1cb21b6 
The problem happened on methods `screen_get_position`,
`screen_get_usable_rect` and `window_set_current_screen` when they were
passed a negative screen value.

Fixes:
- godotengine#46184
- godotengine#46185
- godotengine#46186
@pdfrod pdfrod requested a review from a team as a code owner February 28, 2021 16:46
pouleyKetchoupp
pouleyKetchoupp approved these changes Feb 28, 2021
View reviewed changes
Copy link
Contributor

@pouleyKetchoupp pouleyKetchoupp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I'm not able to test on Linux at the moment, but it seems straightforward as the logic is now the same as in some other methods.

@pouleyKetchoupp pouleyKetchoupp added this to the 4.0 milestone Feb 28, 2021
@pdfrod pdfrod mentioned this pull request Feb 28, 2021
Merged
@akien-mga akien-mga merged commit e3dd38c into godotengine:master Feb 28, 2021
@akien-mga
Copy link
Member

Thanks!

@pdfrod pdfrod deleted the fix-out-of-bounds-acess-on-x11 branch February 28, 2021 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pouleyKetchoupp pouleyKetchoupp pouleyKetchoupp approved these changes

Assignees
No one assigned
Labels
bug crash platform:linuxbsd topic:porting
Projects
None yet
Milestone
4.0
3 participants
@pdfrod @akien-mga @pouleyKetchoupp