Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.3] Fix crash in GLES3 renderer on release builds #47038

Merged
merged 1 commit into from
Mar 22, 2021
Merged

[3.3] Fix crash in GLES3 renderer on release builds #47038

merged 1 commit into from
Mar 22, 2021

Conversation

JFonS
Copy link
Contributor

@JFonS JFonS commented Mar 15, 2021

Make sure the first_directional_light RID is properly invalidated when freed.

Attempt to fix #46960, but I haven't done any thorough test.

@JFonS
Fix crash in GLES3 renderer on release builds
8eb0306 
Make sure the `first_directional_light` RID is properly invalidated when
freed.
@JFonS JFonS added this to the 3.2 milestone Mar 15, 2021
@JFonS JFonS requested a review from a team March 15, 2021 19:53
@JFonS JFonS mentioned this pull request Mar 15, 2021
Open
Base automatically changed from 3.2 to 3.x March 16, 2021 11:12
@akien-mga akien-mga modified the milestones: 3.2, 3.3 Mar 16, 2021
@akien-mga akien-mga changed the title [3.2] Fix crash in GLES3 renderer on release builds [3.3] Fix crash in GLES3 renderer on release builds Mar 16, 2021
@akien-mga akien-mga merged commit a2dd778 into godotengine:3.x Mar 22, 2021
@akien-mga
Copy link
Member

Thanks!

@JFonS JFonS deleted the fix_renderer_rid_crash branch May 4, 2021 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug crash topic:rendering
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
3 participants
@JFonS @akien-mga @clayjohn