Fix a few issues with @export in GDScript #47131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that annotations that rely on the datatype (such as @export) can validated it timely, allowing compound expressions instead of only literal values.
Also fix the enum type in variables to be integer.
vnen
force-pushed
the
gdscript-export-fix
branch
from
1f574f8 to
2b9be53
Compare
|
Rebased now that typed arrays are merged. |
akien-mga
approved these changes
Mar 30, 2021
|
Thanks! |
This was referenced Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main change is to delay the application of annotations until after the types are processed, so a regular
@exportannotation can infer the type even in more complex expressions for the initializer.This also added previously missing support for enums and typed arrays (thus still dependent on #46830, as it was built on top of that branch).
I took the opportunity to fix some bugs as well.
Fix #42023
Fix #41072
Fix #42301
Fix #42022
Fix #42894