Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Ctrl+MouseWheel zooming in VisualShaderEditor and VisualScrptingEditor. #47241

Closed
wants to merge 1 commit into from

Conversation

BuzzBurrowes
Copy link

No description provided.

@BuzzBurrowes BuzzBurrowes requested review from a team as code owners March 21, 2021 20:40
@bruvzg bruvzg changed the base branch from master to 3.x March 21, 2021 20:41
@bruvzg bruvzg requested a review from a team as a code owner March 21, 2021 20:41
@Calinou Calinou removed request for a team March 21, 2021 21:14
@Calinou Calinou removed request for a team March 21, 2021 21:14
@Calinou Calinou added this to the 3.4 milestone Mar 21, 2021
@KoBeWi
Copy link
Member

KoBeWi commented Mar 22, 2021

Isn't this the same as #47173?

@aaronfranke
Copy link
Member

@KoBeWi I think @BuzzBurrowes attempted to open this one for master, but the change is on top of the 3.x branch, so @bruvzg changed the base branch in the PR to reflect that. @BuzzBurrowes should change this PR to actually be based on master.

@YuriSizov
Copy link
Contributor

YuriSizov commented Mar 22, 2021

But it's already implemented on master, and #47173 is a backport of all of the related changes for 3.x.

@BuzzBurrowes
Copy link
Author

Sorry for making the mess here. I was going to submit the change based on the 3.2 branch, but I listened to GitHub when it told me I should submit it to master :-( I should have stuck with my intuition. Also sorry if this has already been addressed someplace. I needed mouse wheel zooming and more zooming depth as I work on a small screen laptop, and even with the map view, I still find it tough to navigate around the graph without being able to zoom out more.

@YuriSizov
Copy link
Contributor

Generally all changes need to first happen in master, and only then can be backported to 3.x. So GitHub didn't lie to you. But indeed, we already have this fixed in master, and there is a pending backport for 3.x. Since your implementation is original, I'll close it in favor of #47173, which is a direct backport.

If you think that your implementation is still better than the one that is already in master, feel free to open a new PR against it.

@BuzzBurrowes
Copy link
Author

Looking at #47173 I can see that it does add mouse wheel zoom, but doesn't add greater zoom depth. My approach is a little more intrusive, but I think by switching to tracking a zoom factor instead of a scale directly it makes for cleaner zooming and less floating-point degradation when zooming in and out a bunch. Also, I see in that pull request the next issue I was going to look at which is related to clicking connection points when zoomed.

So... yeah... I will switch to 3.x locally. Wait for the backport to be committed, and then maybe reapply some of my changes that increase the max zoom factor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants