Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to stop printing to stdout/stderr #47654

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

vnen
Copy link
Member

@vnen vnen commented Apr 5, 2021

This allows the terminal output to be suppressed but still be captured by print/error handlers. Which is useful for a GDScript test suite (cf. #41074).

@vnen vnen added this to the 4.0 milestone Apr 5, 2021
@vnen vnen requested a review from a team as a code owner April 5, 2021 23:52
@Calinou
Copy link
Member

Calinou commented Apr 5, 2021

Isn't there a disable_stdout project setting for that already (and the --quiet command line argument)? We should harmonize this eventually.

@vnen
Copy link
Member Author

vnen commented Apr 6, 2021

Isn't there a disable_stdout project setting for that already (and the --quiet command line argument)? We should harmonize this eventually.

@Calinou this disables printing completely which means the print handlers never get called. What I want here is to still have print handlers but don't output to actual stdout/stderr.

This allows the terminal output to be suppressed but still be captured
by print/error handlers.
@vnen
Copy link
Member Author

vnen commented Apr 6, 2021

Changed to add the flag to OS instead of a global one. This only concerns OS in any case, since it's the one actually doing the printing.

@akien-mga akien-mga merged commit 2d16cca into godotengine:master Apr 6, 2021
@akien-mga
Copy link
Member

Thanks!

@vnen vnen deleted the stdout-disable branch April 6, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants