Add dozens of new integration tests to the GDScript test suite

[Calinou]

This also makes all scripts use tab indentation (except the ones specifically designed to test space indentation or mixed tab/space indentation).

Reviewing tip: Use the file filter to hide .out files in the Files changed tab:

dictionary_consecutive_commas (test that currently crashes)

func test():
	# Dictionaries with consecutive commas are not allowed.
	var dictionary = { "hello": "world",, }

	dictionary = { hello = "world",, }

GDTEST_PARSER_ERROR
Expected expression as dictionary key.

[Xrayez]

Seems like static checks occasionally cause CI errors with *.out files, I think those files should be ignored from static checks eventually. I remedied this problem by stripping and appending the newline for each generated .out file in the original PR, but seems like it's not enough to eliminate those errors completely.

[Calinou]

Seems like static checks occasionally cause CI errors with *.out files, I think those files should be ignored from static checks eventually. I remedied this problem by stripping and appending the newline for each generated .out file in the original PR, but seems like it's not enough to eliminate those errors completely.

This should be fixed now. I've also added a test for the as keyword.

Edit: Removed the parser-features/as.gd test as it caused CI to crash on all platforms with target=release_debug and the default compiler. (It works on my machine with target=debug and Clang on Linux.)

For reference, the code of the test is below:

func test():
	var some_bool = 5 as bool
	var some_int = 5 as int
	var some_float = 5 as float
	print(typeof(some_bool))
	print(typeof(some_int))
	print(typeof(some_float))

	print()

	var some_bool_typed := 5 as bool
	var some_int_typed := 5 as int
	var some_float_typed := 5 as float
	print(typeof(some_bool_typed))
	print(typeof(some_int_typed))
	print(typeof(some_float_typed))

Crash backtrace from macOS:

===============================================================================
./modules/gdscript/tests/gdscript_test_runner_suite.h:43:
TEST SUITE: [Modules][GDScript]
TEST CASE:  Script compilation and runtime

./modules/gdscript/tests/gdscript_test_runner_suite.h:43: FATAL ERROR: test case CRASHED: SIGSEGV - Segmentation violation signal

===============================================================================
[doctest] test cases:  11 |  10 passed | 1 failed | 349 skipped
[doctest] assertions: 104 | 104 passed | 0 failed |
[doctest] Status: FAILURE!
[1] 1   libsystem_platform.dylib            0x00007fff6a3835fd _sigtramp + 29
[2] 2   ???                                 0xf6b0000070001000 0x0 + 17775707731110400000
[3] GDScriptParser::parse_precedence(GDScriptParser::Precedence, bool, bool) (in godot.osx.opt.tools.64) + 397
[4] GDScriptParser::parse_assignment(GDScriptParser::ExpressionNode*, bool) (in godot.osx.opt.tools.64) + 728
[5] GDScriptParser::parse_precedence(GDScriptParser::Precedence, bool, bool) (in godot.osx.opt.tools.64) + 427
[6] GDScriptParser::parse_statement() (in godot.osx.opt.tools.64) + 1080
[7] GDScriptParser::parse_suite(String const&, GDScriptParser::SuiteNode*, bool) (in godot.osx.opt.tools.64) + 600
[8] GDScriptParser::parse_function() (in godot.osx.opt.tools.64) + 678
[9] void GDScriptParser::parse_class_member<GDScriptParser::FunctionNode>(GDScriptParser::FunctionNode* (GDScriptParser::*)(), GDScriptParser::AnnotationInfo::TargetKind, String const&) (in godot.osx.opt.tools.64) + 149
[10] GDScriptParser::parse_class_body() (in godot.osx.opt.tools.64) + 168
[11] GDScriptParser::parse_program() (in godot.osx.opt.tools.64) + 1415
[12] GDScriptParser::parse(String const&, String const&, bool) (in godot.osx.opt.tools.64) + 1891
[13] GDScriptLanguage::get_global_class_name(String const&, String*, String*) const (in godot.osx.opt.tools.64) + 221
[14] GDScriptTests::GDScriptTestRunner::generate_class_index() (in godot.osx.opt.tools.64) + 523
[15] GDScriptTests::GDScriptTestRunner::run_tests() (in godot.osx.opt.tools.64) + 58
[16] GDScriptTests::_DOCTEST_ANON_SUITE_3863::_DOCTEST_ANON_FUNC_3864() (in godot.osx.opt.tools.64) + 112
[17] doctest::Context::run() (in godot.osx.opt.tools.64) + 4566
[18] test_main(int, char**) (in godot.osx.opt.tools.64) + 1244
[19] Main::test_entrypoint(int, char**, bool&) (in godot.osx.opt.tools.64) + 118
[20] main (in godot.osx.opt.tools.64) + 245
[21] 21  libdyld.dylib                       0x00007fff6a186cc9 start + 1
[22] 22  ???                                 0x0000000000000002 0x0 + 2
-- END OF BACKTRACE --

Edit 2: I'm still getting a crash elsewhere unfortunately (but still not locally). I guess I'll have to remove scripts one by one until it stops crashing…

[mhilbrunner]

Built and tested.

tests/scripts/parser/errors/dictionary-consecutive-commas.gd currently crashes the GDScript parser:

func test():
	# Dictionaries with consecutive commas are not allowed.
	var dictionary = { "hello": "world",, }

	dictionary = { hello = "world",, }

[Calinou]

Built and tested.

tests/scripts/parser/errors/dictionary-consecutive-commas.gd currently crashes the GDScript parser.

Fixed 🙂

[mhilbrunner]

@Calinou Whats the state of this? :)

[Calinou]

@Calinou Whats the state of this? :)

It should be mergeable now. We can add more tests later as needed. I rebased it on the latest master branch and ran all tests locally, they all pass.

[mhilbrunner]

CI disagrees :P

[Calinou]

I've added many tests related to heavy nesting of various things in parser/features.

[vnen]

This needs a fix in the GDScript code.

[Calinou]

I don't know how to fix that warning in the GDScript code. Should I ignore it or should I wait for a fix PR to be made first?

[vnen]

I'd say leave like this for now, but open an issue about it.

[vnen]

LGTM. Thanks for working on this.

[akien-mga]

Thanks!

[kleonc]

Should be >>.

[Calinou]

Good catch – I'll fix this in an upcoming PR 🙂

Edit: Fixed in #52718.