Fix mismatch between String and StringName in dictionary keys #48139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the problems mixing String and StringName types when used as dictionary keys. This means users will have to be more careful of what they use as keys.
For reference, this is the expected behavior:
Note that shorthand notation (
dict.a
) assumes the key is a StringName). Also the new StringName literal notation:&"name"
.This PR also makes sure the Lua-style dictionary literal uses StringName as keys, so the shorthand works too:
Fixes #44241
Supersedes #47899