Remove alloca from loop and use a single fixed size array declaration #48926
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As identified by lgtm, #38645 introduced
alloca
in a loop. Unlike memory allocated to a variable, which is reused on every iteration, memory allocated byalloca
is not freed until the calling function returns. Not only does this run the risk of causing a stack overflow, but it neither needsalloca
nor be inside the loop. First, the memory can be allocated using a standard fixed size array, and second, the array can be reused.This PR changes the declaration of
argptrs
to a fixed size array ofconst Variant
pointers and moves the declaration outside the loop.