Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename File::get_len() get_length() #49061

Merged
merged 1 commit into from
May 25, 2021
Merged

Rename File::get_len() get_length() #49061

merged 1 commit into from
May 25, 2021

Conversation

madmiraal
Copy link
Contributor

Makes it consistent with Godot's naming standards.

@madmiraal madmiraal added this to the 4.0 milestone May 25, 2021
@madmiraal madmiraal requested review from a team as code owners May 25, 2021 12:23
akien-mga
akien-mga approved these changes May 25, 2021
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I thought about this too when working on 64-bit buffer support.

@akien-mga akien-mga merged commit f164c00 into godotengine:master May 25, 2021
@akien-mga
Copy link
Member

Thanks!

@madmiraal madmiraal deleted the rename-len-length branch May 25, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xrayez Xrayez Xrayez approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
breaks compat enhancement topic:core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@madmiraal @akien-mga @Xrayez