Remove 16× MSAA support due to driver bugs and low performance #49063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanfranke
reviewed
Jul 4, 2021
In the `master` branch, 16× MSAA caused the entire system to freeze on NVIDIA GPUs. This is likely caused by graphics drivers not actually implementing 16× MSAA, but combining 8× MSAA with 2× SSAA instead. On top of that, modern shader complexity makes 16× MSAA very difficult to use while keeping a good framerate. 8× MSAA is hard enough to use as it is.
Calinou
force-pushed
the
remove-16x-msaa
branch
from
965dffd to
7192852
Compare
akien-mga
approved these changes
Sep 13, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
masterbranch, 16× MSAA caused the entire system to freeze on NVIDIA GPUs. This is likely caused by graphics drivers not actually implementing 16× MSAA, but combining 8× MSAA with 2× SSAA instead. If you need to implement a "photo mode" for high quality in-game screenshots, you can combine 2× SSAA with 8× MSAA manually.On top of that, modern shader complexity makes 16× MSAA very difficult to use while keeping a good framerate. This is especially true when you start using GIProbe or SDFGI. 8× MSAA is hard enough to use as it is, and it's not much of a loss visually compared to 16× MSAA.
In the
3.xbranch, there are only minor bugs with 16× MSAA such as #14727, so I think we can keep it there. Shaders are also not as complex in3.x, so higher MSAA values are more usable in practice.This closes #37917.