Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GDScript: Fix inner classes and preloaded scripts as types #49105

Merged
merged 5 commits into from
Aug 20, 2021
Merged

GDScript: Fix inner classes and preloaded scripts as types #49105

merged 5 commits into from
Aug 20, 2021

Conversation

vnen
Copy link
Member

@vnen vnen commented May 26, 2021

Fix #47063

@vnen vnen added this to the 4.0 milestone May 26, 2021
@vnen vnen requested a review from a team as a code owner May 26, 2021 12:25
@vnen vnen force-pushed the gdscript-inner-preload-type branch from 047dab8 to 30c0433 Compare May 26, 2021 19:26
@akien-mga
Copy link
Member

The unit test seems to fail.

@vnen vnen force-pushed the gdscript-inner-preload-type branch from 30c0433 to 23b4353 Compare June 3, 2021 12:53
@vnen
Copy link
Member Author

vnen commented Jun 3, 2021

Added a couple of commits to fix bugs and pass the tests.

@akien-mga
Copy link
Member

There seems to be memory leaks detected by LSAN.

@vnen
Copy link
Member Author

vnen commented Jun 8, 2021

I fixed the leak but now something is being freed too soon and crashing. Not sure what's happening, seems like there's a deeper problem with the system.

@qarmin
Copy link
Contributor

qarmin commented Aug 17, 2021

Looks that crash should be fixed by #51762

@vnen vnen force-pushed the gdscript-inner-preload-type branch from a7df46f to 89695da Compare August 18, 2021 21:59
@vnen
GDScript: Make singleton functions be seen as static
2e84a46 
Since those can be called without an instance.
@akien-mga akien-mga merged commit f5422c5 into godotengine:master Aug 20, 2021
@akien-mga
Copy link
Member

Thanks!

@vnen vnen mentioned this pull request Oct 15, 2021
Closed
@vnen vnen deleted the gdscript-inner-preload-type branch April 18, 2022 16:29
@lyuma lyuma mentioned this pull request Oct 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:gdscript
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

GDScript 2.0: Preloaded classes and inner clases cannot be used as type declarations
3 participants
@vnen @akien-mga @qarmin