Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the audio bus editor appearance #49130

Merged
merged 1 commit into from
May 31, 2021
Merged

Improve the audio bus editor appearance #49130

merged 1 commit into from
May 31, 2021

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented May 27, 2021 •
edited
Loading

Follow-up to #32020.

  • Use the editor font color for notch lines and text instead of a more contrasted color.
  • Reuse the editor theme's tooltip styling and apply it on theme change (for run-time dark -> light theme changes and vice versa).
  • Make the preview label display an explicit + sign for positive values.
  • Prevent a zero value from displaying as -0.0 dB instead of 0.0 dB.
  • Scale notch lines on hiDPI displays.

Preview

Before After
Before After

@Calinou
Improve the audio bus editor appearance
534c990 
- Use the editor font color for notch lines and text instead of a more
  contrasted color.
- Reuse the editor theme's tooltip styling and apply it on theme change.
- Make the preview label display an explicit `+` sign for positive values.
- Prevent a zero value from displaying as `-0.0 dB` instead of `0.0 dB`.
- Scale notch lines on hiDPI displays.
@Calinou Calinou added this to the 4.0 milestone May 27, 2021
@YuriSizov YuriSizov requested a review from a team May 27, 2021 08:41
@fire
Copy link
Member

fire commented May 27, 2021

What did it look before?

@Calinou
Copy link
Member Author

Calinou commented May 27, 2021 •
edited
Loading

What did it look before?

I added a "before" comparison image to OP 🙂

Changes are mainly noticeable on hiDPI displays or when using the light theme.

fire
fire approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on the appearance of the before screenshot and the after screenshot.

The lighter font is weird.

+1 on the plus sign and the canonical 0 representation. I wonder if canonical 0 display can be moved up an abstraction.

Did not QA.

@akien-mga akien-mga merged commit 04b85ad into godotengine:master May 31, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label May 31, 2021
@Calinou Calinou mentioned this pull request Jul 18, 2021
Closed
@Calinou Calinou deleted the editor-improve-audio-bus-theming branch August 3, 2021 15:59
@YuriSizov YuriSizov mentioned this pull request Sep 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@groud groud groud approved these changes

@fire fire fire approved these changes

Assignees
No one assigned
Labels
bug enhancement topic:audio topic:editor usability
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Calinou @fire @akien-mga @groud