Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VisualScriptFunctionNodes Improvements #49749

Merged
merged 1 commit into from
Jul 21, 2021
Merged

VisualScriptFunctionNodes Improvements #49749

merged 1 commit into from
Jul 21, 2021

Conversation

Gallilus
Copy link
Contributor

@Gallilus Gallilus commented Jun 19, 2021 •
edited
Loading

This PR improves and streamlines the workflow for VisualScriptFunctionNodes. Call Set Get
Removes redundant method_select popup
And Fix issues with drop offset and instancing Set Get

Supersedes #49184
Supersedes #49172
Fixes #26717
Fixes #49146
Possible Fix #37053

Editor changes

  • Fix issue when of dropposition when in different zoom levels.
  • Fix drag in Set and Get.

VisualScriptFuncNode's changes

  • Harmonize and improve the visual representation of the VisualScriptFuncNode's and there different modes.
  • Update Functionality of VisualScriptFunctionGet to include pass when using instance mode.

example project.zip
example script.zip

screeshot

caption = what text (sequence) = where / object info I-O's = details

Original

image

@Gallilus Gallilus requested a review from a team as a code owner June 19, 2021 19:39
@Gallilus Gallilus mentioned this pull request Jun 19, 2021
Closed
@Calinou Calinou added this to the 4.0 milestone Jun 19, 2021
@YeldhamDev
Copy link
Member

Small typo in the commit message: "Imrovements"

@Gallilus Gallilus changed the title VisualScriptFunctionNodes Imrovements VisualScriptFunctionNodes Improvements Jun 20, 2021
@Gallilus Gallilus requested review from a team as code owners June 20, 2021 19:14
@Gallilus Gallilus mentioned this pull request Jun 22, 2021
Closed
@Gallilus Gallilus force-pushed the VisualScriptFunction_Call_Set_Get_Improvement-2 branch from f175e44 to 667c15f Compare June 22, 2021 14:29
@Chaosus Chaosus requested a review from fire June 22, 2021 15:55
@fire
Copy link
Member

fire commented Jun 22, 2021

Reviewing.

fire
fire approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@fire fire left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improving the situation.

  1. Reviewed the code.
  2. Reviewed the example photo
  3. Still need test with demo projects to see the visual scripting's effect.

Please try further QA and resolve the style changes.

Approved on the design.

Note:
Trying to create a get_position on Node2D crashes. Cannot reproduce again.

modules/visual_script/visual_script_editor.cpp Outdated Show resolved Hide resolved
modules/visual_script/visual_script_editor.h Outdated Show resolved Hide resolved
@Gallilus
Copy link
Contributor Author

@fire, sorry I'm confused.
Please try further QA and resolve the style changes. Is this directed at me?
Do I need to make it with nullptr's? Do you have a example?

@Gallilus Gallilus force-pushed the VisualScriptFunction_Call_Set_Get_Improvement-2 branch 2 times, most recently from 21fa35a to 49511c2 Compare June 22, 2021 20:17
@Gallilus Gallilus mentioned this pull request Jun 23, 2021
Merged
@Gallilus Gallilus force-pushed the VisualScriptFunction_Call_Set_Get_Improvement-2 branch 4 times, most recently from d880388 to eec4d40 Compare June 25, 2021 20:04
@Gallilus
Copy link
Contributor Author

@fire
Tested even got a few small extras that where overlooked.
Set Basic Type now has sequence ports.
Ready for merge

@charlesmlamb
Copy link

Thanks, for this, every improvement to Visual script matters to me, Godot 4 will be amazing . .

@Gallilus
Copy link
Contributor Author

Do I need a new approval before it is possible to merge?
I'm dreaming of getting this to 3.x before 3.3.3

@Calinou
Copy link
Member

Calinou commented Jul 20, 2021 •
edited
Loading

I'm dreaming of getting this to 3.x before 3.3.3

Following the versioning change, 3.3.x will only get bug fixes. New features will be available in 3.4. This is to make sure 3.3.x remains as stable as possible and avoid regressions.

akien-mga
akien-mga approved these changes Jul 20, 2021
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assign from a small style issue, this seems pretty solid. I'm not very familiar with VisualScript but it seems to improve UX, and we can iterate further from there.

@akien-mga
Copy link
Member

Once merged, feel free to make a PR to backport the changes to 3.x for inclusion in 3.4. But please also make sure that the changes do not break compatibility for existing scripts (I think not, but again I don't know much about VisualScript).

@Gallilus
Improve and streamline VisualScriptFuncNodes Call Set Get
10b4cb7 
This PR improves and streamlines the workflow for VisualScriptFunctionNodes Call Set Get
Uniform design.
Drag in set-get from tree is now working.
Removes redundant method_select popup.
@Gallilus Gallilus force-pushed the VisualScriptFunction_Call_Set_Get_Improvement-2 branch from eec4d40 to 10b4cb7 Compare July 21, 2021 08:17
@akien-mga akien-mga merged commit b5f5fac into godotengine:master Jul 21, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga mentioned this pull request Jul 21, 2021
Closed
@Gallilus
Copy link
Contributor Author

Gallilus commented Jul 21, 2021 •
edited
Loading

Real time support of Rémi is Awesome!!

This was referenced Jul 21, 2021
Merged
Merged
@Gallilus Gallilus deleted the VisualScriptFunction_Call_Set_Get_Improvement-2 branch July 24, 2021 10:37
@Gallilus Gallilus mentioned this pull request Apr 27, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@fire fire fire approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor topic:visualscript
Projects
None yet
Milestone
4.0
6 participants
@Gallilus @YeldhamDev @charlesmlamb @fire @Calinou @akien-mga