Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent accidental drags by adding drag distance threshold (3.x) #50508

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jul 16, 2021

3.x version of #49310. Thanks @foxydevloper for the initial implementation!

Note that this PR uses a lowered threshold as requested (8 pixels instead of 10 pixels), and the 2D editor threshold is now scaled with the zoom to behave consistently at all zoom levels.

Co-authored-by: fox <12120644+foxydevloper@users.noreply.github.com>
@xix-xeaon
Copy link

I just want to say, the kind of work you do is often thankless, since each thing is just a small thing. But you do many of these small things and they add up. You are solving issues that thousands of users are dealing with every day but often aren't worth reporting on - many don't even realize they're issues.

Each one individually of no great importance but together they become the entire user experience. The work you do ensures that Godot attains a level of professionalism seen in commercial projects and elevates it far above the sum of it's parts. Thank you!

I'm singling out @Calinou here because I'm constantly seeing his name over and over in the pull requests, but anyone else who submits small, seemingly unworthy, fixes (even just a single one) know that you too deserve to bask in a share of this glory =)

@akien-mga akien-mga merged commit 9636dea into godotengine:3.x Jul 17, 2021
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the add-drag-threshold-select-mode-3.x branch August 3, 2021 15:57
@Calinou Calinou changed the title Prevent accidental drags by adding drag distance threshold Prevent accidental drags by adding drag distance threshold (3.x) Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants