Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clamp negative colors regardless of the tonemapper to avoid artifacts #51439

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Aug 9, 2021

3.x version of #51436.

Color artifacts could be visible when using negative lights with the Filmic and ACES tonemapping operators, as these did not clamp negative colors.

Preview

Linear

Before After
2021-08-09_17 06 02 2021-08-09_17 15 30

Reinhard (already clamped before this PR)

Before After
2021-08-09_17 06 18 2021-08-09_17 15 36

Filmic

Before After
2021-08-09_17 06 22 2021-08-09_17 15 41

ACES

Before After
2021-08-09_17 06 27 2021-08-09_17 15 47

Color artifacts could be visible when using negative lights with the
Filmic and ACES tonemapping operators, as these did not clamp negative
colors.
@akien-mga akien-mga merged commit 5116855 into godotengine:3.x Aug 10, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.3.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants