Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move 3D scene import classes to their own folder #51569

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

aaronfranke
Copy link
Member

@aaronfranke aaronfranke commented Aug 12, 2021

This PR moves 3D scene import classes to their own folder (editor/import/3d). Previously the 3D scene import classes were in the same place as mostly unrelated files such as texture and audio importers.

@aaronfranke aaronfranke added this to the 4.0 milestone Aug 12, 2021
@aaronfranke aaronfranke requested a review from a team as a code owner August 12, 2021 13:10
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have an opinion, merge if desired.

The only problem is this breaks prs and on-going development churn, but that is expected from pr developers.

Copy link
Member

@mhilbrunner mhilbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR meeting: We should agree on a proposal on how to reorg the editor code

@aaronfranke aaronfranke requested a review from a team as a code owner December 20, 2022 06:25
@aaronfranke aaronfranke requested a review from a team as a code owner July 16, 2023 04:02
Copy link
Contributor

@lyuma lyuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know @fire approved this back in 2021. I also think this is reasonable, so I'm going to put my approval on here too to make clear that there is nothing in terms of asset pipeline that is blocking this.

editor/import/SCsub Outdated Show resolved Hide resolved
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Jan 4, 2024
@akien-mga akien-mga merged commit b9ae7f7 into godotengine:master Jan 5, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

6 participants