Don't handle property_editor shortcuts on release. #52376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes godotengine#52336. EditorProperty::unhandled_key_input was handling both press and release. This means that if you press `ctrl+v` on an EditorProperty line input, it will paste as expected on pressing `ctrl+v`, and accept the event so EditorProperty will not see it. However, on release, LineEdit ignores the event and EditorProperty still catches and handles it, using its own paste implementation.
akien-mga
approved these changes
Sep 16, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52336.
EditorProperty::unhandled_key_input was handling both press and release.
This means that if you press
ctrl+von an EditorProperty line input,it will paste as expected on pressing
ctrl+v, and accept the event soEditorProperty will not see it. However, on release, LineEdit ignores
the event and EditorProperty still catches and handles it, using its own
paste implementation.