Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 3D Onion skinning missing #52667

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Fix 3D Onion skinning missing #52667

merged 1 commit into from
Sep 14, 2021

Conversation

butkeim
Copy link
Contributor

@butkeim butkeim commented Sep 14, 2021 •
edited by akien-mga
Loading

Fixes #52412 (I can do a branch specific issue if needed)

3D Onion skinning was missing since #22225

AnimationPlayerEditorPlugin::forward_spatial_force_draw_over_viewport implementation was missing.

I renamed AnimationPlayerEditor::forward_canvas_force_draw_over_viewport to forward_force_draw_over_viewport for coherency.

Bugsquad edit: master version of #52664.

@akien-mga akien-mga added this to the 4.0 milestone Sep 14, 2021
@akien-mga akien-mga mentioned this pull request Sep 14, 2021
Merged
@akien-mga akien-mga requested review from RandomShaper and a team September 14, 2021 13:02
@akien-mga akien-mga merged commit cd5a8f8 into godotengine:master Sep 14, 2021
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandomShaper RandomShaper RandomShaper approved these changes

Assignees
No one assigned
Labels
bug topic:animation topic:editor topic:3d
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

3D Onion skinning not working
3 participants
@butkeim @akien-mga @RandomShaper