[3.x] Add type validations when setting basic type #53464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LATRio
changed the title
akien-mga
reviewed
Jan 5, 2022
|
Also, #53456 should be checked against the |
akien-mga
reviewed
Jan 6, 2022
core/variant_call.cpp
Outdated
| if (!E) { | ||
| return Vector<Variant::Type>(); | ||
| } | ||
| ERR_FAIL_COND_V(!E, Vector<Variant::Type>()); |
There was a problem hiding this comment.
We discussed this in a review meeting, the ERR_FAIL_INDEX_V are good, but we're not confident that the change from if (!E) to an error condition is good. There's a risk that these methods might actually be used with non-existing methods at times and the code expects it to return an empty/default value.
Since it's not part of the fix for the reported bug, it's probably best to leave this part alone (same in other methods, only validate p_type).
akien-mga
force-pushed
the
3.x
branch
2 times, most recently
from
71cb8d3 to
c58391c
Compare
akien-mga
approved these changes
Jan 8, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #53456