Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to add RESET values from existing keys #55653

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Dec 5, 2021

This PR adds a way to quickly create RESET values from existing animation keys. It's useful when importing old animations or when you just want to update the RESET value to match another animation.
zibBZvsvCx

If multiple keys are selected, only the first selected key in a track will get a RESET value:
wrjJSw6IWH

Closes #55634

@KoBeWi KoBeWi added enhancement topic:editor usability cherrypick:3.x Considered for cherry-picking into a future 3.x release topic:animation labels Dec 5, 2021
@KoBeWi KoBeWi added this to the 4.0 milestone Dec 5, 2021
@akien-mga akien-mga merged commit a68401d into godotengine:master Dec 6, 2021
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the branch December 6, 2021 13:59
@securas
Copy link

securas commented Dec 6, 2021

Nice! Thanks!

@akien-mga
Copy link
Member

@KoBeWi I did a backport for 3.x in my local branch, and it seems to work, but it raises an error when adding a reset track this way:

 scene/resources/animation.cpp:881 - Index p_track = 0 is out of bounds (tracks.size() = 0).

This is the commit in my fork (didn't push to upstream 3.x yet): akien-mga@10d200c

I didn't check if it's reproducible in master.

@KoBeWi
Copy link
Member Author

KoBeWi commented Dec 6, 2021

I don't know how I missed this error, I'll make a hotfix >_>

@akien-mga
Copy link
Member

Cherry-picked for 3.5. (Together with #55671.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reset track not created with animation nodes from 3.3.x
3 participants