Improve compilation time with include-what-you-use (editor folder)
#57734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 7, 2022
Geometror
changed the title
editor folder)editor folder)
|
Closing, see #57760 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #57641, but in this PR the includes are generated by include-what-you-use (there was still some manual work required). The changes are restricted to the
editorfolder since this cleanup should be done bit for bit.[Alternative to #57641 which is purely manual]
EDIT: Part of a series of PRs to reduce the compilation time with include-what-you-use together with some manual fixes due to the complexity of the codebase. [see #57760, #57759]
Although the full potential will only be developed when iwyu is run over a larger part of the codebase, there is already a significant improvement:
1 file changed (filesystem_dock.h)
0:43 min -> 0:33 min
4 files changed (editor_file_dialog.h/file_dialog.h/dependency_editor.cpp/filesystem_dock.h)
4:07 min -> 3:23 min