Fix tileset editor visiblity and selection context #58361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait, need to change something... |
SaracenOne
force-pushed
the
tileset_editor_selection
branch
from
7f8f0d2 to
e2d5db1
Compare
|
Okay, should be sorted now. Silly oversight on my behalf |
groud
reviewed
Feb 21, 2022
…n tileset is available
SaracenOne
force-pushed
the
tileset_editor_selection
branch
from
e2d5db1 to
04535bd
Compare
|
Updated to be a tad less hacky |
groud
reviewed
Feb 22, 2022
| @@ -158,6 +158,9 @@ void TilesEditorPlugin::_update_editors() { | |||
| // Update the viewport. | |||
| CanvasItemEditor::get_singleton()->update_viewport(); | |||
|
|
|||
| // Make sure the tile set editor is visible if we have one assigned. | |||
| tileset_editor_button->set_visible(is_visible && tile_set.is_valid()); | |||
There was a problem hiding this comment.
I am not sure I understand why this is needed. Wasn't this already working?
Reading what is in make_visible() it seems like this is already done.
There was a problem hiding this comment.
@groud Sorry, I completely forgot about this, but I remember it now because I'm doing another pass over all the editor plugins at the moment. With regards to this visibility check, it needs both checks to be successful otherwise the tileset button will still be visible even when you aren't highlighting a tileset node.
akien-mga
approved these changes
Jul 28, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes sure the tileset editor is automatically selected when editing a tileset by clicking on it from the tilemap property in the insepctor. Also makes sure the tileset editor button's visibility is immediately toggled when a tileset is assigned or unassigned from a currently selected tilemap node.
Closes #56413