Implement get_bone_final_pose() to Skeleton3D
#58863
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As commented, this should be only work with some sort of "sync" warranty if you have many consumers of this method. IMO the new skeleton modification stack should be better? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refactoring done in #55840 requires a more in-depth discussion because of it affects to large area.
For now, the current problem in my case is that we can't get the final displayed pose because of the mix of
local_pose_overrideandglobal_pose_overrideand the difficulty in knowing from outside Skeleton whether they override the original pose.As a minimum implementation, I implemented
get_bone_final_pose()as a function that returns the original pose if there are no overrides, and returns the local pose that takes into account the overrides if there are.