-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Fix alpha scissor support #58954
Conversation
Sorry about the repush, just realized that I forgot to remove an unnecessary pair of brackets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the mobile renderer need the same changes?
Right, there are two vulkan renderers in master... I keep forgetting the mobile one every single time. |
servers/rendering/renderer_rd/forward_mobile/scene_shader_forward_mobile.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Thanks for your patience.
Thanks! |
Fixes #58924 in master.
Apparently, the alpha scissor check was lost in the transition from gles3 to vulkan. In addition materials with alpha scissors were still using the default shadow material, which obviously resulted in wrong shadows.