[3.x] Add context support for editor translation #59187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're now able to translate property paths and later probably also enum & flags hints. It's more and more likely to encounter situations where the same word/message is used to mean different things. So I think it's necessary to backport the context feature from #40443.
Context is only added to
TTR()-related functions and not exposed to scripting for backward compatibility.In addition to the
extract.pyand PO parsing changes from the original PR. ATranslationsubclassContextTranslationis created to support i18n with context.TranslationLoaderPO::load_translation()will returnContextTranslationinstead of the vanilla version when requested. This only happens when loading editor translations.