Display the build date in the editor and when starting the engine #59247
+69
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronRecord
reviewed
Mar 17, 2022
Calinou
force-pushed
the
editor-display-build-date
branch
2 times, most recently
from
5b718ac to
082dad5
Compare
Calinou
force-pushed
the
editor-display-build-date
branch
2 times, most recently
from
34a6b50 to
945b26d
Compare
Mickeon
reviewed
Feb 25, 2024
Calinou
force-pushed
the
editor-display-build-date
branch
from
945b26d to
ce6ffaf
Compare
Calinou
commented
Feb 26, 2024
Comment on lines
+2488
to
+2489
| // Don't use rich formatting to prevent ANSI escape codes from being written to log files. | ||
| print_header(false); |
There was a problem hiding this comment.
This is a workaround for #36252 (comment), which we could remove once we have support for stripping ANSI escape codes in RotatedFileLogger.
|
Rebased and tested again, it works as expected. |
KoBeWi
reviewed
Feb 27, 2024
|
Needs to be rebased once more for the Engine docs rework on that part specifically. |
akien-mga
reviewed
Feb 27, 2024
akien-mga
approved these changes
Feb 27, 2024
Calinou
force-pushed
the
editor-display-build-date
branch
from
ce6ffaf to
63784aa
Compare
Mickeon
approved these changes
Feb 27, 2024
This can be used to quickly see how recent a development build is, without having to look up the commit date manually. When juggling around with various builds (e.g. for benchmarking), this can also be used to ensure that you're actually running the binary you intended to run. The date stored is the date of the Git commit that is built, not the current date at the time of building the binary. This ensures binaries can remain reproducible. The version timestamp can be accessed using the `timestamp` key of the `Engine.get_version_info()` return value.
Calinou
force-pushed
the
editor-display-build-date
branch
from
63784aa to
67e9ccd
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be used to quickly see how recent a development build is, without having to look up the commit date manually. When juggling around with various builds (e.g. for benchmarking), this can also be used to ensure that you're actually running the binary you intended to run.
The date stored is the date of the Git commit that is built, not the current date at the time of building the binary. This ensures binaries can remain reproducible.
The version timestamp can be accessed using the
timestampkey of theEngine.get_version_info()return value.I've tested all possible scenarios and they all build successfully:
gitin PATH,.git/folder present (the only scenario in whichVERSION_TIMESTAMPis not0).gitnot in PATH,git/folder present.gitin PATH,.git/folder not present.gitnot in PATH,git/folder not present.Preview