Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update root order on layer change #59479

Merged

Conversation

Sauermann
Copy link
Contributor

@Sauermann Sauermann commented Mar 24, 2022

When the layer of a CanvasLayer changes, the order of viewport root controls needs to be recalculated.

fix #59448

@Sauermann Sauermann requested a review from a team as a code owner March 24, 2022 18:16
@Calinou Calinou added this to the 4.0 milestone Mar 24, 2022
When the layer of a CanvasLayer changes, the order of roots needs to be recalculated.
@rohanrhu
Copy link
Contributor

Can you please check and merge this PR? This is a very important bug 😭

@rohanrhu
Copy link
Contributor

Yayyyyy buttt we need to cherrypick this to Godot 3.5 🤭

@KoBeWi KoBeWi added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Sep 15, 2022
@akien-mga akien-mga merged commit ad0349c into godotengine:master Nov 2, 2022
@akien-mga
Copy link
Member

Thanks!

@Sauermann Sauermann deleted the fix-rootorder-on-layerchange branch November 2, 2022 13:26
@timothyqiu
Copy link
Member

Cherry-picked for 3.6.

@timothyqiu timothyqiu removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjusting CanvasLayers layer on runtime, does not update _gui_input handling to match the visual rendering
7 participants