Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the changed field to empty (meaning all) if the link button is pressed #62903

Conversation

Rindbee
Copy link
Contributor

@Rindbee Rindbee commented Jul 11, 2022

Quick fix #62283.

This is due to the p_field in the EditorProperty::emit_changed. p_field only works for MultiNodeEdit, not for other objects.

It feels like there is no need to make it a condition in MultiNodeEdit either.

This is due to the `p_field` in the `EditorProperty::emit_changed`.
`p_field` only works for `MultiNodeEdit`, not for other objects.
@Rindbee Rindbee changed the title Fix property link not working in MultiNodeEdit Set the changed field to empty (meaning all) if the link button is pressed Jul 11, 2022
@Calinou Calinou added this to the 4.0 milestone Jul 11, 2022
@akien-mga akien-mga merged commit 78a9a3d into godotengine:master Sep 15, 2022
@akien-mga
Copy link
Member

Thanks!

@Rindbee Rindbee deleted the fix-property-link-not-work-in-MultiNodeEdit branch September 15, 2022 19:19
@timothyqiu timothyqiu added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Dec 17, 2022
@timothyqiu
Copy link
Member

timothyqiu commented Dec 17, 2022

Cherry-picked for 3.6.

@timothyqiu timothyqiu removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Property linking doesn't work in MultiNodeEdit
5 participants