Fix editor dock layout not saving correctly #62919
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57142
When saving the editor dock layout, the
dock_[...]
keys were never erased whennames
was empty, causing the config to keep the old values for these keys.For example, if you had:
And you moved
Node
todock_2
, this was the result:It now makes sure the key is erased if
names
is empty (it also erases it even if it's non-empty, so the keys are always ordered correctly in the config).This issue was caused by a regression from #48466