Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default value display of method arguments for GDScript documentation and Tooltips #62934

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Fix default value display of method arguments for GDScript documentation and Tooltips #62934

merged 1 commit into from
Aug 10, 2022

Conversation

Xwdit
Copy link
Contributor

@Xwdit Xwdit commented Jul 12, 2022

Fix #62933

@Xwdit Xwdit requested a review from a team as a code owner July 12, 2022 03:12
@Chaosus Chaosus added this to the 4.0 milestone Jul 12, 2022
@akien-mga
Copy link
Member

Could you squash the commits? See PR workflow for instructions.

@Xwdit Xwdit force-pushed the script_doc_arg_def_var branch 2 times, most recently from 7d1f2a0 to 56f41de Compare July 14, 2022 01:37
@Xwdit
Copy link
Contributor Author

Xwdit commented Jul 14, 2022 •
edited
Loading

Could you squash the commits? See PR workflow for instructions.

Thanks for the reminder, I have squashed the commits

@Xwdit Xwdit mentioned this pull request Jul 14, 2022
Open
@Xwdit Xwdit changed the title Fix default value display of method arguments for GDScript documentation Fix default value display of method arguments for GDScript documentation and Tooltips Jul 15, 2022
@Xwdit Xwdit mentioned this pull request Jul 15, 2022
Merged
@Xwdit @akien-mga
Fix script documentation method argument default values
f265f17 
Co-Authored-By: Rémi Verschelde <rverschelde@gmail.com>
@Xwdit Xwdit force-pushed the script_doc_arg_def_var branch from 56f41de to f265f17 Compare August 10, 2022 13:07
@akien-mga akien-mga merged commit 345dd9f into godotengine:master Aug 10, 2022
@akien-mga
Copy link
Member

Thanks!

@Xwdit Xwdit deleted the script_doc_arg_def_var branch August 10, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:editor topic:gdscript
Projects
No open projects
GDScript Stabilization Tasks
Status: Done
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

GDScript comment documentation does not show default values for functions arguments
3 participants
@Xwdit @akien-mga @Chaosus