Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix document not showing for gdscript properties in inspector #62936

Merged
merged 1 commit into from
Jul 31, 2022

Conversation

Xwdit
Copy link
Contributor

@Xwdit Xwdit commented Jul 12, 2022

Fix #59270

@akien-mga
Copy link
Member

Looks good! Could you squash the commits? See PR workflow for instructions.

@Xwdit Xwdit force-pushed the script_doc_inspector_property branch from 045967e to 8ee125a Compare July 14, 2022 01:33
@Xwdit
Copy link
Contributor Author

Xwdit commented Jul 14, 2022

Looks good! Could you squash the commits? See PR workflow for instructions.

OK, I have squashed it

@akien-mga akien-mga merged commit 214d0b2 into godotengine:master Jul 31, 2022
@akien-mga
Copy link
Member

Thanks!

@lufog
Copy link
Contributor

lufog commented Aug 6, 2022

Is this broken again? Seems to not work anymore.

It seems to work, at least for me. Checked on c81ef51.
image

Upd: Found your problem. If you add a comment to an already exported variable, it does not appear until the editor is reloaded. If you add a comment before the variable is exported, it is displayed immediately.

@bfeber, will you open an issue, or should I?

@gb2dev
Copy link
Contributor

gb2dev commented Aug 6, 2022

@bfeber, will you open an issue, or should I?

Dew it.

@lufog
Copy link
Contributor

lufog commented Aug 6, 2022

@Xwdit, could you please take a look at #63997?

@Xwdit Xwdit deleted the script_doc_inspector_property branch August 6, 2022 13:17
@Xwdit
Copy link
Contributor Author

Xwdit commented Aug 6, 2022

@Xwdit, could you please take a look at #63997?

I'll take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GDScript 2.0: Documentation comments do not appear in inspector tooltips
5 participants