Test, refactor and fix a bug in Basis.get_axis_angle #63428
Merged
+81
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Jul 25, 2022
akien-mga
reviewed
Jul 25, 2022
fabriceci
force-pushed
the
fix-basis-get-axis-angle
branch
8 times, most recently
from
621a16f to
4f5e9df
Compare
fabriceci
added
cherrypick:3.x
akien-mga
reviewed
Sep 5, 2022
akien-mga
approved these changes
Sep 5, 2022
aaronfranke
reviewed
Sep 5, 2022
fabriceci
force-pushed
the
fix-basis-get-axis-angle
branch
from
4f5e9df to
3a41cba
Compare
fabriceci
force-pushed
the
fix-basis-get-axis-angle
branch
from
3a41cba to
9f1a57d
Compare
|
Thanks! |
|
This would require a manual backport for 3.x, it's not trivial to cherry-pick. |
akien-mga
removed
cherrypick:3.x
akien-mga
pushed a commit
to JuanFdS/godot
that referenced
this pull request
Jun 7, 2023
Backport of godotengine#63428. Co-authored-by: juanFdS <juan9794@gmail.com>
akien-mga
pushed a commit
to akien-mga/godot
that referenced
this pull request
Aug 18, 2023
Backport of godotengine#63428. Co-authored-by: juanFdS <juan9794@gmail.com> (cherry picked from commits 8245fd3 and d1c8c5d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #63190
Fix #63397
Fix #65179
I understand this code better now and I found where this code came from, there was a slight difference on the end of the algorithm, I used the original one, especially as it is used in many libraries such as three.js, it seems safer that way.
I cleaned up the code a bit and added some tests.