Move rpc and rpc_id implementations back to header #63820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
aaronfranke
approved these changes
Aug 2, 2022
There was a problem hiding this comment.
I can confirm that this resolves the linker errors. It's a slightly different solution than what I came up with, in this PR they are in the header but not inside the node class declaration. Also, it occurred to me that it might be worth adding a comment saying that they must be in the header.
StackOverflow on why this is needed: https://stackoverflow.com/questions/495021/why-can-templates-only-be-implemented-in-the-header-file Minor mistake in commit ca7d572
nathanfranke
force-pushed
the
templates-in-header
branch
from
bd500ce to
c3c5985
Compare
nathanfranke
commented
Aug 2, 2022
aaronfranke
approved these changes
Aug 3, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this concern: #63049 (comment)
StackOverflow on why this is needed (TL;DR templates must be in header): https://stackoverflow.com/questions/495021/why-can-templates-only-be-implemented-in-the-header-file
I think the reason why this wasn't causing much issues in the engine is right now there are no engine components that use RPCs.