Fix OmniLight/SpotLight shadow opacity calculation #64110
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When turning off the
shadow
property ofOmniLight
/SpotLight
, the shadow was still rendered while the shadow atlas was no longer updated. This PR fixes the shadow opacity calculation so that it behaves the same as for directional lights. There is still some room for improvement, e.g. clear/free the shadow buffer(if possible) but that would require a significantly more complex approach.Bugsquad edit: This closes #50343.