Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the drawing logic clearer in Button #64351

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Make the drawing logic clearer in Button #64351

merged 1 commit into from
Jan 18, 2024
+282 −223

Commits on Jan 18, 2024

  1. Make the drawing logic clearer in Button 

    The drawing logic follows the calculation logic in `Button::get_minimum_size`.

According to the order of `stylebox`, `icon`, and `text`, and follow properties
such as alignment mode, to fill the display space of the button.

Add a `Button::_set_h_separation_is_valid_when_no_text` for Button derived
classes (like `OptionButton`) that expects a `h_separation` between `icon`
and theme icon even if the `text` is empty.
    @Rindbee
    Rindbee committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    f29a7d3 View commit details
    Browse the repository at this point in the history