Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for viewport's input handling #65424

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

RedMser
Copy link
Contributor

@RedMser RedMser commented Sep 6, 2022

Documentation for methods and members related to input handling of the viewport.

Some of this might be a better fit for its own documentation page (such as Using InputEvent), but I'm not sure how to link to a tutorial in a method's description (or if that's even possible).

@RedMser RedMser requested a review from a team as a code owner September 6, 2022 14:27
doc/classes/Viewport.xml Outdated Show resolved Hide resolved
doc/classes/Viewport.xml Outdated Show resolved Hide resolved
@Sauermann
Copy link
Contributor

Great work! I made a few improvement suggestions.
I can't say anything about the functionality of handle_input_locally, but all other changes are looking good to me.

@RedMser RedMser force-pushed the viewport-input-docs branch 2 times, most recently from 3e0f82d to d4579c1 Compare October 2, 2022 16:12
doc/classes/Viewport.xml Outdated Show resolved Hide resolved
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase and a fix, otherwise seems good.

@RedMser RedMser force-pushed the viewport-input-docs branch from d4579c1 to f6aec6c Compare October 5, 2022 10:54
@RedMser RedMser force-pushed the viewport-input-docs branch from f6aec6c to 5ae012e Compare October 5, 2022 10:56
Copy link
Member

@mhilbrunner mhilbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akien-mga akien-mga merged commit ec2bda3 into godotengine:master Oct 5, 2022
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants