-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an editor option to copy system info to clipboard #65902
Conversation
See also godotengine/godot-proposals#4732, which proposes a more elaborate solution. That said, I think the way this PR works is pretty good already. I'd consider it sufficient to close godotengine/godot-proposals#4732 🙂 |
@Calinou: Indeed. For now, I wanted to get something useful for everybody real quick. I want to go full fancy with this later, but still thinking about grouping data and so. Thanks for the proposal reference. I'll take some inspiration from steam/blender |
33ffadf
to
954d338
Compare
e8bdcf1
to
6c4cc07
Compare
@Calinou / @akien-mga: This PR has been updated with merge of #66102. Are code and info selection ok like this? |
ping @Calinou / @akien-mga |
6c4cc07
to
779c92b
Compare
abeeaa9
to
5973ea9
Compare
@Calinou: done. I merged Godot version and System information into Environment information to reflect the new Editor functionality. What do you think? EDIT: I can extract Godot version again, if you think this would cause more harm than do good preview: |
938d66d
to
ba513bc
Compare
plus minor static-related fixes * linuxbsd: get_systemd_os_release_info_value() -> static breaks usage if used multiple times * windows/linuxbsd: get_video_adapter_driver_info() writes info into static * linuxbsd: get_distribution_name() + get_version() -> write bsd fallback into static variable * windows/uwp/android: remove unnecessary use of static
ba513bc
to
9e5bf3d
Compare
Thanks! |
Unfortunately, using a multiline text field in the issue template prevents browser autocompletion from working (since browsers only autocomplete singled-line inputs). I'm thinking we should revert that particular change as I personally rely on this a lot (and so does @KoBeWi). @MJacred Could you make the button copy a single-line output (separating each element with |
that's totally understandable. jeeze, what a pain in the neck…
Yeah, sounds reasonable. And then also remove the |
I think a single line with all this information might be pretty verbose / hard to parse visually. Ubuntu 20.04.5 LTS - Godot 4.0.beta.custom_build - Vulkan (Forward+) - NVIDIA GeForce GTX 970 (driver 510.85.02) - Intel(R) Core(TM) i7-10700KF CPU @ 3.80GHz (16 Threads) Maybe even like this it might be a bit too much. (BTW we should also get the commit hash for the Godot version, which is more useful than |
Yeah, that's why this is a pain in the neck… Removing the info classifications ("OS", "Godot Version", etc.) sounds feasible
Hm… should be possible with version.h/
I'll make a PR. Then we can check it out directly |
EDIT: The output result of this PR was changed to single-line in this PR to better align with the GitHub bug reporting template:
new output format:
Godot v4.1.dev (bc19b5abf) - Ubuntu 20.04.6 LTS (Focal Fossa) - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 970 (nvidia; 510.108.03) - Intel(R) Core(TM) i7-10700KF CPU @ 3.80GHz (16 Threads)
Closes godotengine/godot-proposals#4732 (Author said it's fine)
copies markdown friendly syntax into clipboard
Will add graphics card driver name + version info in a future PR, once I've made more progress (got it figured out for Linux)DONE ✔️