Do not allow editing Scene-inherited signal connections #66665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mickeon
force-pushed
the
editor-do-not-edit-inherited-signals
branch
3 times, most recently
from
1b529db to
7d05ead
Compare
akien-mga
approved these changes
Oct 13, 2022
|
Found a bug. Connecting an instance blocks disconnecting until reload. godot.windows.editor.dev.x86_64_vouq1whwx5.mp4 |
KoBeWi
reviewed
Oct 13, 2022
KoBeWi
reviewed
Oct 13, 2022
Hmm... It technically makes sense. I wonder how to address this one... |
|
It's not important tbh, so it can be fixed later (e.g. when someone opens an issue xd) |
KoBeWi
approved these changes
Oct 13, 2022
Inherited connections are also highlighted with the warning color in the Node dock.
Mickeon
force-pushed
the
editor-do-not-edit-inherited-signals
branch
from
7d05ead to
6a77563
Compare
|
Reflecting on the bug more, to solve it would mean to change the way direct scene connections are detected, to do a bit of the opposite of what it is currently doing. Which is basically Godot going "Oh, I don't see this signal within the list. Therefore it has to be inherited" but as you showed, it isn't necessarily true. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12373.
Editing inherited signal connections has never actually really worked, in practice.
In fact, saving and reopening the Scene makes all inherited connections appear again, as if no change has even happened. Very strange to let the user touch them, in the first place. It really has no effect. Nor it probably should, as it would lead to an unorganised workflow.
This PR makes it so that signal connections from an inherited Scene can no longer be modified in any way in the Editor.
Inherited connections are displayed in warning yellow (same as inherited Nodes) and they cannot be edited or removed.
Likewise, "Disconnect All" will not disconnect inherited connections, and is disabled if no connection can be disconnected.
