[3.x] Never duplicate script with Resource.duplicate()
#66975
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mickeon
changed the title
script with Resource.duplicate()script with Resource.duplicate()
Mickeon
force-pushed
the
3.x-fix-resource-duplicate-script
branch
from
e96e0cc
to
48c8b97
Compare
|
@Mickeon should this be closed, given the PR meeting went with a different approach in 4.x? #65374 (comment) Maybe #71142 should be backported? |
|
Probably so? Not too fond of yet another usage flag, but it makes perfect sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.x version of #65374
Excludes the
scriptproperty of a Resource from being ever duplicated. This doesn't mean that a Script resource cannot ever be duplicated, however.