Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blender/fbx2gltf tooltip for where the filepath is #66983

Closed
wants to merge 1 commit into from
Closed

Add blender/fbx2gltf tooltip for where the filepath is #66983

wants to merge 1 commit into from

Conversation

TheYellowArchitect
Copy link
Contributor

@TheYellowArchitect TheYellowArchitect commented Oct 6, 2022

Basically an extension of this godotengine/godot-proposals#5547 because its impossible to add a button to redirect to editor settings. Users will easily stumble into project settings import blender/fbx2gltf enabled checkbox, but 99% of the times they want to set the path instead, and the old tooltip requests to change a file, instead of doing it the easy way of opening editor settings.

This is my first time I pull request onto godotengine, and I do not know if this file is auto-generated. Feel free to deny this commit or edit it. My arguments are in the above issue tl;dr: user doesn't know where to set blender/fbx filepath, the tooltip mentions a file change, and hovering over to redirect to editor settings is intuitive.

I also added a URL to V-Sekai FBX2glTF utility. I do not know if the styling is to be in [url=], or if explicitly redirecting to a 3rd party tool within the engine is even encouraged, so freely delete that line.

Basically an extension of this godotengine/godot-proposals#5547 because its impossible to add a button to redirect to editor settings.
Users will easily stumble into this, but 99% of the times they want to set the path instead, and the old tooltip requests to change a file, instead of doing it the easy way of opening editor settings.

This is my first time I pull request onto godotengine, and I do not know if this file is auto-generated. Feel free to deny this commit or edit it. My arguments are in the above issue tl;dr: user doesn't know where to set blender/fbx filepath, and hovering over to redirect ftw

I also added a url to V-Sekai FBX2glTF utility. I do not know if the styling is to be in [url=], or if its even encouraged, so freely delete that line.
@TheYellowArchitect TheYellowArchitect requested a review from a team as a code owner October 6, 2022 12:47
@Calinou
Copy link
Member

Calinou commented Oct 6, 2022

See also #59810, which is a more thorough solution for improving the FBX import experience.

@Calinou Calinou added this to the 4.0 milestone Oct 6, 2022
@TheYellowArchitect
Copy link
Contributor Author

TheYellowArchitect commented Oct 6, 2022

Wow, I missed that. It is indeed a superior solution to just adding 2 lines on tooltips lol
After all, validating fbx/blender executable is something much needed as well, which I mentioned in the original issue godotengine/godot-proposals#5547 but didn't know its already implemented

Thank you for notifying me. I will keep an eye on it, and if its merged, I will close this pull request which is honestly a band-aid

@TheYellowArchitect TheYellowArchitect closed this by deleting the head repository Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants