Expose functionalities of CanvasItemEditor to GDScript, through EditorInterface
#68706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiongyaohua
changed the title
CanvasItemEditor to GDScriptCanvasItemEditor through EditorInterface to GDScript
xiongyaohua
changed the title
CanvasItemEditor through EditorInterface to GDScriptCanvasItemEditor to GDScript, through EditorInterface
xiongyaohua
force-pushed
the
expose_canvasitemeditor
branch
from
640e92f to
b3f0cbd
Compare
xiongyaohua
force-pushed
the
expose_canvasitemeditor
branch
3 times, most recently
from
079e825 to
66b11ae
Compare
xiongyaohua
force-pushed
the
expose_canvasitemeditor
branch
from
66b11ae to
d685d94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writing 2D editor plugins in GDScript use some hacky work around to interact with
CanvasItemEditor.This PR exposes, This PR exposes some functionalities ofCanvasItemEditordirectlyCanvasItemEditorthroughEditorInterface, in order to make life of 2D plugin writer easier.Currently only methods that are essential for 2D editor plugin are exposed. More functionalities (such as snapping and tool state) can be exposed if there is demand. See godotengine/godot-proposals#1302 for discussion.
Another PR address the same problem with different ways. I am not familiar with Godot enough to tell which is the better way. Hope reviewer could shed some light.