Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent editor crash when deleting children of GraphNode #69284

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Prevent editor crash when deleting children of GraphNode #69284

merged 1 commit into from
Dec 5, 2022

Conversation

John-Gdi
Copy link
Contributor

@John-Gdi John-Gdi commented Nov 28, 2022 •
edited by akien-mga
Loading

Solve #69082 by adding avaliable child checking.

Bugsquad edit:

@John-Gdi John-Gdi requested a review from a team as a code owner November 28, 2022 07:32
@John-Gdi John-Gdi mentioned this pull request Nov 28, 2022
Closed
akien-mga
akien-mga reviewed Nov 28, 2022
View reviewed changes
scene/gui/graph_node.cpp Outdated Show resolved Hide resolved
@YuriSizov YuriSizov added this to the 4.0 milestone Nov 28, 2022
@YuriSizov YuriSizov requested a review from Geometror November 28, 2022 09:24
YuriSizov
YuriSizov suggested changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formally marking as "Request changes", see the discussion above.

akien-mga
akien-mga reviewed Nov 29, 2022
View reviewed changes
scene/gui/graph_node.cpp Outdated Show resolved Hide resolved
@YuriSizov YuriSizov changed the title To solve the editor crashes when deleting children of GraphNode Prevent editor crash when deleting children of GraphNode Nov 29, 2022
@YuriSizov
Copy link
Contributor

When you will be updating your PR next, please amend the commit message as well. I've edited the title of your PR, you can use that.

@John-Gdi John-Gdi requested review from YuriSizov and removed request for Geometror December 2, 2022 00:56
YuriSizov
YuriSizov approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YuriSizov YuriSizov merged commit d759210 into godotengine:master Dec 5, 2022
@YuriSizov
Copy link
Contributor

YuriSizov commented Dec 5, 2022 •
edited
Loading

Thanks! And congratulations on the first merged pull request, I think! 🎉

@John-Gdi John-Gdi deleted the bugfix-69082 branch January 9, 2023 03:31
This was referenced Jan 19, 2023
Closed
Closed
@JaythFactor JaythFactor mentioned this pull request Mar 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga left review comments

@YuriSizov YuriSizov YuriSizov approved these changes

Assignees
No one assigned
Labels
bug crash topic:editor topic:gui
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Editor crashes when deleting children of GraphNode
4 participants
@John-Gdi @YuriSizov @akien-mga @mhilbrunner