Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ProjectSetting overrides #71325

Merged

Commits on Jan 13, 2023

  1. Refactor ProjectSetting overrides

    * Overrides no longer happen for set/get.
    * They must be checked with a new function: `ProjectSettings::get_setting_with_override()`.
    * GLOBAL_DEF/GLOBAL_GET updated to use this
    
    This change solves many problems:
    * General confusion about getting the actual or overriden setting.
    * Feature tags available after settings are loaded were being ignored, they are now considered.
    * Hacks required for the Project Settings editor to work.
    
    Fixes godotengine#64100. Fixes godotengine#64014. Fixes godotengine#61908.
    reduz committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    6f0e210 View commit details
    Browse the repository at this point in the history