Support script global resource name in EditorFileSystem #71687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reduz
commented
Jan 19, 2023
| @@ -1117,6 +1122,57 @@ String ResourceLoaderBinary::recognize(Ref<FileAccess> p_f) { | |||
| return get_unicode_string(); | |||
| } | |||
|
|
|||
| String ResourceLoaderBinary::recognize_script_class(Ref<FileAccess> p_f) { | |||
reduz
force-pushed
the
support-script-class-name-in-efs
branch
from
94ab46a to
48feb8e
Compare
|
I tested the performance and it's fine. (i.e. there is no significant Quick Open slowdown) |
KoBeWi
reviewed
Jan 19, 2023
KoBeWi
reviewed
Jan 19, 2023
KoBeWi
reviewed
Jan 19, 2023
KoBeWi
reviewed
Jan 19, 2023
reduz
force-pushed
the
support-script-class-name-in-efs
branch
2 times, most recently
from
8b48b11 to
ce3ca63
Compare
YuriSizov
reviewed
Jan 20, 2023
doc/classes/ProjectSettings.xml
Outdated
Comment on lines
655
to
661
| <member name="dotnet/project/assembly_name" type="String" setter="" getter="" default=""""> | ||
| Name of the .NET assembly. This name is used as the name of the [code].csproj[/code] and [code].sln[/code] files. By default, it's set to the name of the project ([member application/config/name]) allowing to change it in the future without affecting the .NET assembly. | ||
| </member> | ||
| <member name="dotnet/project/solution_directory" type="String" setter="" getter="" default=""""> | ||
| Directory that contains the [code].sln[/code] file. By default, the [code].sln[/code] files is in the root of the project directory, next to the [code]project.godot[/code] and [code].csproj[/code] files. | ||
| Changing this value allows setting up a multi-project scenario where there are multiple [code].csproj[/code]. Keep in mind that the Godot project is considered one of the C# projects in the workspace and it's root directory should contain the [code]project.godot[/code] and [code].csproj[/code] next to each other. | ||
| </member> |
There was a problem hiding this comment.
Make sure your PR doesn't remove these lines (even though doctool does remove them for you).
There was a problem hiding this comment.
I'm adding a hack to keep those like we used to have with the old Mono: #71728.
But indeed until it's merged / this PR rebased on top, you need to make sure to keep them when committing (and restore them for now).
akien-mga
approved these changes
Jan 21, 2023
reduz
force-pushed
the
support-script-class-name-in-efs
branch
from
ce3ca63 to
ca5688e
Compare
KoBeWi
reviewed
Jan 21, 2023
reduz
force-pushed
the
support-script-class-name-in-efs
branch
from
ca5688e to
464ec04
Compare
* Works for binary and text files. * Makes EditorQuickOpen work with custom resources again. * Information is cached and easily accessible. Properly fixes godotengine#66179. Supersedes godotengine#66215 and supersedes godotengine#62417 **WARNING**: This required breaking backwards binary compatibility (.res and .scn files). Files saved after this PR is merged will no longer open in any earlier versions of Godot.
reduz
force-pushed
the
support-script-class-name-in-efs
branch
from
464ec04 to
dddd8d4
Compare
KoBeWi
approved these changes
Jan 21, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly fixes #66179. Supersedes #66215 and supersedes #62417
WARNING: This required breaking backwards binary compatibility (.res and .scn files). Files saved after this PR is merged will no longer open in any earlier versions of Godot.