Add remove immutable tracks option to glTF importer #72342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Lyuma <xn.lyuma@gmail.com>
TokageItLab
force-pushed
the
immutabletrack
branch
from
dc5c944 to
8b3be51
Compare
akien-mga
approved these changes
Jan 30, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Lyuma xn.lyuma@gmail.com
Supersedes #72007. Fixes #71525.
In some cases, this rest-match optimization can be a bad thing, but in most cases it should not be a problem. It should be optional. As I mentioned in #72007 (comment), it is hard work to associate Skeleton with Animation in the Scene importer (Post import), so it is reasonable to have this in the glTF importer.
Also, it is recommended that optimization be done by default, since the problematic case should be rare.