Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more debug information to swapchain errors in Vulkan context #72858

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

clayjohn
Copy link
Member

@clayjohn clayjohn commented Feb 7, 2023

Part of #71929

We are getting a lot of random lockups that either spam or print:

E 0:00:01:0015   VulkanContext::swap_buffers: Condition "err" is true. Returning: ERR_CANT_CREATE
  <C++ Source>   drivers\vulkan\vulkan_context.cpp:2299 @ VulkanContext::swap_buffers()
E 0:00:01:0016   VulkanContext::prepare_buffers: Vulkan: Did not create swapchain successfully.
  <C++ Error>    Condition "err != VK_SUCCESS" is true. Breaking.
  <C++ Source>   drivers\vulkan\vulkan_context.cpp:2222 @ VulkanContext::prepare_buffers()

Unfortunately, the lockup happens randomly and it is very difficult to reproduce.

This PR adds the actual VKResult error to the print so user reports can tell us what Vulkan error is being produced and distinguishes the print statements so we can identify where they are coming from better.

@clayjohn clayjohn added this to the 4.0 milestone Feb 7, 2023
@clayjohn clayjohn requested a review from a team as a code owner February 7, 2023 21:40
@clayjohn clayjohn force-pushed the VK-swap-buffers-err branch from a044312 to 22291d7 Compare February 7, 2023 21:52
@clayjohn
Copy link
Member Author

clayjohn commented Feb 7, 2023

@akien-mga Thank you for the comments. I have addressed them all and force pushed

@akien-mga akien-mga merged commit 1258de0 into godotengine:master Feb 8, 2023
@akien-mga
Copy link
Member

Thanks!

@clayjohn clayjohn deleted the VK-swap-buffers-err branch February 8, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants